Artifacts

# Add typed error codes to document processing module

## Current State

Status: review
Current phase: final
Next: scafld review add-error-codes
Reason: build complete; review gate ready
Allowed follow-up command: scafld review add-error-codes
Review gate: not_started

## Acceptance

Validation:
- [x] v1 compile - Project compiles with no type errors
  - Command: npm run build
  - Status: pass
  - Evidence: exit=0 duration=4.2s
- [x] v2 test - Unit tests pass
  - Command: npm test -- --filter documents
  - Status: pass
  - Evidence: exit=0 duration=2.1s

## Harden Rounds

### round-1

Status: passed
Started: 2026-05-13T00:10:00Z
Ended: 2026-05-13T00:18:00Z
Verdict: pass
Provider: codex
Model: gpt-5.5
Output format: codex.output_file
Summary: The draft contract survived path, command, timing, rollback, and design challenge checks.

Checks:
- Path audit
  - Grounded in: code:internal/app/review/context.go:30
  - Result: passed
  - Evidence: Target package and docs paths exist; new docs file is declared.
- Command audit
  - Grounded in: code:Makefile:1
  - Result: passed
  - Evidence: `make check` is the repository validation command.
- Scope/migration audit
  - Grounded in: spec_gap:Risks
  - Result: passed
  - Evidence: No compatibility fallback or data migration is introduced.
- Acceptance timing audit
  - Grounded in: spec_gap:Phases
  - Result: passed
  - Evidence: Criteria run after the parser and docs updates are in place.
- Rollback/repair audit
  - Grounded in: spec_gap:Rollback
  - Result: not_applicable
  - Evidence: Change is source-only and reverts cleanly through git.
- Design challenge
  - Grounded in: spec_gap:Summary
  - Result: passed
  - Evidence: The plan names the underlying review failure, removes the escape hatch at the root, and avoids a compatibility fallback.

Issues:
- [low/advisory] `harden-1` question - The rollback could name a recovery command.
  - Status: open
  - Grounded in: spec_gap:Rollback
  - Evidence: Rollback is credible but terse.
  - Recommendation: Name the recovery command if already known.
  - Question: What should a human run if the cutover fails?
  - Recommended answer: Use the package's existing repair command.
  - If unanswered: Keep rollback as-is; do not block approval.

{
  "ok": true,
  "command": "status",
  "result": {
    "task_id": "add-error-codes",
    "status": "review",
    "next": "scafld review add-error-codes",
    "gate": "review",
    "trusted_state": "session ledger replay projected into the Markdown spec",
    "allowed_follow_up": "scafld review add-error-codes",
    "session_ok": true
  }
}

gate: review
status: review
reason: review provider failed
evidence:
- .scafld/runs/add-error-codes/diagnostics/command-1.txt
expected: valid ReviewDossier submitted by an external reviewer
actual: provider produced no submission; Claude must call submit_review exactly once and final text is ignored
blockers:
- review provider failed
next: scafld handoff add-error-codes

## Context Budget Manifest

Max section body bytes: 16384
Rendered section body bytes: 9211
Omitted section body bytes: 1840

Included sections:
- `task_contract` (Task Contract): rendered=822 body=822 omitted=0
- `task_changes` (Task Changes Since Approval Baseline): rendered=1410 body=1410 omitted=0

Truncated sections:
- `project_context:README.md` (Project Context: README.md): rendered=800 body=1900 omitted=1100 sources=`README.md`

Omitted sections:
- `project_context:docs/review.md` (Project Context: docs/review.md): rendered=0 body=740 omitted=740 sources=`docs/review.md` reason=context budget exhausted

{
  "verdict": "fail",
  "mode": "discover",
  "summary": "One completion blocker found.",
  "findings": [
    {
      "id": "missing-error-envelope-mapping",
      "severity": "high",
      "blocks_completion": true,
      "category": "Spec Compliance",
      "confidence": "high",
      "location": {"path": "src/errors/document-error.ts", "line": 44},
      "evidence": "DocumentProcessingError exposes code but the API adapter still serializes message only.",
      "impact": "Callers cannot branch on the new typed error code.",
      "validation": "Add an API adapter test asserting the response envelope includes code.",
      "status": "open",
      "summary": "Typed error codes are not exposed at the API boundary."
    }
  ],
  "attack_log": [
    {
      "target": "error envelope callers",
      "attack": "Trace serialization from processor errors to API response",
      "result": "finding"
    }
  ],
  "budget": {
    "max_findings": 12,
    "min_attack_angles": 6,
    "actual_findings": 1,
    "actual_attack_angles": 1,
    "depth": "standard"
  },
  "provider": "codex",
  "output_format": "codex.output_file"
}